[FIX] Admin page crashing when commit hash is null#22057
Merged
ggazzo merged 5 commits intoRocketChat:developfrom Jul 1, 2021
cprice-kgi:develop
Merged
[FIX] Admin page crashing when commit hash is null#22057ggazzo merged 5 commits intoRocketChat:developfrom cprice-kgi:develop
ggazzo merged 5 commits intoRocketChat:developfrom
cprice-kgi:develop
Conversation
ggazzo
previously approved these changes
May 21, 2021
ggazzo
reviewed
Jun 21, 2021
ggazzo
approved these changes
Jun 21, 2021
gabriellsh
added a commit
that referenced
this pull request
Jul 1, 2021
…ite/create_disc * 'develop' of github.com:RocketChat/Rocket.Chat: (27 commits) [IMPROVE] Preview message URLs only once (#22516) [FIX] Admin page crashing when commit hash is null (#22057) [FIX] Unnecessary space on members list footer (#22514) Chore: Review some dependencies (#22522) Chore: Meteor 2.2 and bump dependencies (#22399) Chore: Remove Sodium from the main client (#22459) [FIX] Prune messages from particular user(s) (#22506) [FIX] Livechat apps permission error (#22511) [IMPROVE] Message deletion modal #22508 Update README.md Update README.md [IMPROVE] Add pagination to tags, and improve current Agents pagination [FIX] Rewrite CurrentChats to TS (#22424) [FIX] Sort AutocompleteDepartmentsMultiple (#22419) [FIX] Put title into AutocompleteDepartment components (#22417) [FIX] Bugs in AutoCompleteDepartment (#22414) [FIX] Closed chats doesn't show who picked the call (#22368) [FIX] Omnichannel Real Time Monitoring chart not displaying chats-per-agent and chats-per-department (#22406) [IMPROVE] Paginated multiselect for EE tags (#22315) [FIX] Units Edit and adds the option to hide own department in useDepartmentList ...
|
I have similar issue with node version on my test deployment |
Member
|
can you create an issue with more information about it, please @ankar84? |
Unfortunately yesterday we restore db from production deployment to that test deployment and now there is not that problem there - info page opens normally. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
If the commit hash happens to be null, the administration page will still attempt to slice the value and display it. This causes the admin page to not display, and essentially crash the web app. This fixes it by checking for a null value first.
Issue(s)
closes #22031
Steps to test or reproduce
Attempt to access the admin page in an environment where the deployed code does not have a commit hash value. Apparently this is the case when using the zip archive from the github releases page, but certainly there could be other scenarios that replicate a null commit hash.
Further comments